Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85565?usp=email )
Change subject: mb/google/rauru: Add SD card configurations ......................................................................
Patch Set 9:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85565/comment/eabd2d13_982980aa?usp... : PS2, Line 12: TEST=Build pass.
Were you able to run-time test it?
Done
https://review.coreboot.org/c/coreboot/+/85565/comment/8b5c90d1_420315e3?usp... : PS2, Line 16: Andy-ld
Is -ld part of the name?
yes
https://review.coreboot.org/c/coreboot/+/85565/comment/d2d1fc30_77ea7cf0?usp... : PS2, Line 17:
Jarried, please add your Signed-off-by line, as you are in the author field.
I think the current Signed-off-by line is fine with me because the main effort is still on Andy. Thanks.
Commit Message:
https://review.coreboot.org/c/coreboot/+/85565/comment/c490d020_d5fd5401?usp... : PS7, Line 16: BUG=b:317009620
Move `BUG` to the top of `TEST`.
Done
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85565/comment/0f8c925f_95626b2f?usp... : PS2, Line 14: #include <soc/msdc.h>
sort
Done