Attention is currently required from: Maciej Pijanowski.
Sergii Dmytruk has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/coreboot/+/82692?usp=email )
Change subject: util/smmstoretool: explain what happens when no store is found ......................................................................
Patch Set 2:
(1 comment)
File util/smmstoretool/storage.c:
https://review.coreboot.org/c/coreboot/+/82692/comment/b3fab015_1401cebd?usp... : PS2, Line 53: fprintf(stderr, : "Variable store has not been found in the binary and will " : "be initialized now.\nIt is expected if release binary is " : "used, as variable store normally is initialized on the " : "first boot of the platform.\n"); I'd format the message differently (also somewhat updated it, e.g. "binary" was too generic):
```suggestion fprintf(stderr, "\nThe variable store has not been found in the ROM image\n" "and is about to be initialized. This situation is normal\n" "for a release image, as the variable store is usually\n" "initialized on the first boot of the platform.\n\n");
```
I just don't like unusually long strings in the output and long sequence of ungrouped sentences are hard to read as well (e.g. like `flashrom` does), this version produces the following output:
``` No firmware volume header present No valid firmware volume was found
The variable store has not been found in the ROM image and is about to be initialized. This situation is normal for a release image, as the variable store is usually initialized on the first boot of the platform.
Successfully created variable store in "coreboot.rom" ```