SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35534 )
Change subject: mb/google/kohaku: Set mmio_pl1_override value for tablet mode
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35534/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35534/1/src/mainboard/google/hatch/...
PS1, Line 4: 5
how did you arrive to number as 5W ? and it's not clear from here that this value is only applicable […]
The CLs for separate PL1 setting for tablet mode are pending now,
waiting for Intel team's response about enabling advanced DPTF feature.
https://partnerissuetracker.corp.google.com/issues/138395625
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35534
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79bea32cf46ffa50f83af3905f85a471cb94b339
Gerrit-Change-Number: 35534
Gerrit-PatchSet: 1
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 18 Oct 2019 00:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment