mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31225 )
Change subject: src/mainboard/lenovo/g505s/Kconfig: disable DRIVERS_INTEL_WIFI by default ......................................................................
Patch Set 2:
I think that until we find at least one G505S user who needs Intel WiFi we could safely default it to "n". Why default this to "y" if we don't know anyone who needs it?
Patch Set 2:
I'm not aware of any G505s's shipped with an Intel wifi adapter either, but I can't really prove a negative.
There is a hardware maintenance manual PDF at https://github.com/g505s-opensource-researcher/g505s-proprietary/tree/master... , which among others lists only Intel 135 as the supported replacement, but if you search the Internet you could not find any G505S with it - only some other Ideapad G-series Intel laptops which have been mentioned at this manual. To me it's a good enough proof.
Patch Set 2:
You can have 100% open software with 0% security, as well as 0% open with 100% security.
If there is no tivoization you could upgrade the security of your open software to 100% or pay someone to do it, meanwhile you could not consider 0% open software to be 100% secure because you couldn't just blindly trust the maker of this software who claims it is "100% secure" and the community couldn't audit it since the sources are closed.
Patch Set 2:
If "most x86 platforms could have" any of the other listed generic drivers, should they be enabled globally too so people can disable them?
I think the difference with other generic drivers is that e.g. if there is no TI TPS65913 at your board then it couldn't ever have it, while these MiniPCI-e modules are add-on and could be added. But because I haven't heard of anyone who has G505S with Intel WiFi inside, I think it is safe to disable by default.
My point is that the default settings should suit the needs of majority, especially considering that in this particular case it's likely that minority doesn't exist. Meanwhile I've already found myself a couple of times in a situation where I had to disable DRIVERS_INTEL_WIFI in order to save a few kilobytes to make enough remaining room for the last floppy image of my interest