[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common/gpio: Add open-drain GPIO macros

[Julius Werner (Code Review)]

Attention is currently required from: Cliff Huang, Nick Vaccaro.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74841 )

Change subject: soc/intel/common/gpio: Add open-drain GPIO macros
......................................................................

Patch Set 1:

(1 comment)

File src/include/gpio.h:

https://review.coreboot.org/c/coreboot/+/74841/comment/1bff86a1_ac3a61f1 
PS1, Line 18: void gpio_set_HiZ(gpio_t gpio_num);
I don't really think these belong here in the platform-independent API as separate calls. Usually the way we do things is that we have platform-specific functions that can configure the GPIO in the right mode (e.g. whether it's open-drain or push-pull), and then calling gpio_set() on it should do the right thing for the respective mode.

Alternatively, you can basically consider gpio_input() the equivalent of gpio_set_HiZ(), and gpio_input_pulldown() the equivalent of gpio_od_set(..., 0) (and then pullup -> 1).