HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41676 )
Change subject: src: Remove duplicated includes ......................................................................
Patch Set 1:
(10 comments)
https://review.coreboot.org/c/coreboot/+/41676/1/src/mainboard/51nb/x210/rom... File src/mainboard/51nb/x210/romstage.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/mainboard/51nb/x210/rom... PS1, Line 8: #include <string.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/mainboard/google/fizz/m... File src/mainboard/google/fizz/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/mainboard/google/fizz/m... PS1, Line 22: <variant/gpio.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/amd/common/block/ac... PS1, Line 10: <halt.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/amd/common/block/lp... PS1, Line 5: <device/device.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/intel/braswell/nort... File src/soc/intel/braswell/northcluster.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/intel/braswell/nort... PS1, Line 5: cpu/x86/smm.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/mediatek/common/dsi... File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/mediatek/common/dsi... PS1, Line 6: <device/mmio.h duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/mediatek/mt8173/i2c... File src/soc/mediatek/mt8173/i2c.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/mediatek/mt8173/i2c... PS1, Line 7: device/mmio.h duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/soc/mediatek/mt8173/i2c... PS1, Line 9: soc/i2c.h duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/southbridge/amd/agesa/h... PS1, Line 7: amdblocks/acpimmio.h duplicated
https://review.coreboot.org/c/coreboot/+/41676/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/41676/1/src/southbridge/amd/pi/huds... PS1, Line 8: amdblocks/acpimmio.h duplicated