Attention is currently required from: Sean Rhodes, Tarun Tuli, Michał Żygowski, Subrata Banik, Paul Menzel, Arthur Heymans.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71715 )
Change subject: soc/intel/alderlake: Hook up PchHdaAudioLinkHdaEnable to devicetree ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4: Looks like chrome doesn't need the HDA Link. But if your board needs it, it make sense to add it. Below is FSP log for HDA on chrome.
[SPEW ] ------------------ HD Audio PreMem Config ------------------ [SPEW ] Enable = 1 [SPEW ] DSP Enable = 1 [SPEW ] DSP UAA Compliance = 0 [SPEW ] Audio Link: HDA Link = 0 [SPEW ] Audio Link: DMIC#0 = 0 [SPEW ] DMIC#0 Clock Select = 0 [SPEW ] Audio Link: DMIC#1 = 0 [SPEW ] DMIC#1 Clock Select = 0 [SPEW ] Audio Link: SSP#0 = 0 [SPEW ] Audio Link: SSP#1 = 0 [SPEW ] Audio Link: SSP#2 = 0 [SPEW ] Audio Link: SSP#3 = 0 [SPEW ] Audio Link: SSP#4 = 0 [SPEW ] Audio Link: SSP#5 = 0 [SPEW ] Audio Link: SoundWire#1 = 0 [SPEW ] Audio Link: SoundWire#2 = 0 [SPEW ] Audio Link: SoundWire#3 = 0 [SPEW ] Audio Link: SoundWire#4 = 0 [SPEW ] VC Type = 0 [SPEW ] iDisp Codec Disconnect = 0 [SPEW ] iDisp Link Frequency = 4 [SPEW ] iDisp Link T-Mode = 3 [SPEW ] ResetWaitTimer = 258 [SPEW ] Hda Sdi0 Enable = 1 [SPEW ] Hda Sdi1 Enable = 0 [SPEW ] SubSystemIds = 0