Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Ronak Kanabar, Patrick Rudolph.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57141 )
Change subject: soc/intel/alderlake: Change VBOOT_HASH_BLOCK_SIZE to 4 KiB
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/57141/comment/d1d90a82_a415a205
PS2, Line 270: help
: Default hash block size is 1KiB. Increasing it to 4KiB to improve
: hashing time as well as read time. This helps in improving
: boot time for Alder Lake.
Good point, it's not really "help" text, maybe just add a comment indicating why it deviates from th […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9222761c7d58e4a370d3a41c651b6c169599d792
Gerrit-Change-Number: 57141
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 25 Aug 2021 16:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment