Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33552 )
Change subject: mb/google/octopus: Override DDI1 DDC SDA/SCL for Garg HDMI
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33552/4/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/#/c/33552/4/src/mainboard/google/octopus/variant...
PS4, Line 46: DISPUPD),
What does it mean by "others (no PU)"? […]
Hi Marco,
for HDMI, we usually select 2.2K resistor since if it has internal PU 20K as shunt resistance.
the value will decrease to 1.98K, it might have peak concern for EMI. thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ad8e5aa52f503121b10fe353e4bf4021aee2061
Gerrit-Change-Number: 33552
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Jun 2019 03:18:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-MessageType: comment