Attention is currently required from: Lance Zhao, Philipp Hug, Tim Wawrzynczak, ron minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74808 )
Change subject: ACPI,SMBIOS : Provide ACPI and SMBIOS support for RISC-V ......................................................................
Patch Set 1:
(96 comments)
File src/acpi/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/bc278798_d2ddbffd PS1, Line 390: static void acpi_create_pptt (acpi_header_t *pptt) space prohibited between function name and open parenthesis '('
File src/arch/riscv/tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/14816d47_9fe23b5f PS1, Line 27: unsigned long high_table_pointer, new_high_table_pointer;; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/c13da519_bd76ea95 PS1, Line 34: memset ((void *)high_table_pointer, 0, MAX_SMBIOS_SIZE); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ba34c33a_a7f27a15 PS1, Line 64: memset ((void *)high_table_pointer, 0, max_acpi_size); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/081cde2e_8912a1be PS1, Line 88: const char *config_path[] = { "cfgtables", NULL }; char * array declaration might be better as static const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/db899925_66e8845a PS1, Line 108: if (smbios_entry) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/6445118b_5257c829 PS1, Line 121: if (dt) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/9918a015_c7843a6a PS1, Line 128: } trailing whitespace
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ecb6079e_f0fa6fd0 PS1, Line 104: { CBMEM_ID_FDT, "FDT " }, \ please, no space before tabs
File src/include/acpi/acpi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/7e374195_91501293 PS1, Line 242: u64 lo; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/5bc7d7ca_0b8c7b9b PS1, Line 243: u64 hi; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/f2ec23b2_a842f390 PS1, Line 248: struct { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/cdf4350a_02749940 PS1, Line 249: u32 lhxw : 4; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/1442d56c_f18d6e34 PS1, Line 249: u32 lhxw : 4; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/d455e1ff_25b9feef PS1, Line 250: u32 hhxw : 3; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/6af0080d_78cea8e5 PS1, Line 250: u32 hhxw : 3; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/3a6ccba4_21dd312a PS1, Line 251: u32 lhxs : 3; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/071686b1_5fcb94c3 PS1, Line 251: u32 lhxs : 3; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/35ee80e4_79cdbdc1 PS1, Line 252: u32 hhxs : 5; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/8c2f2c5a_a3409c9b PS1, Line 252: u32 hhxs : 5; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/32f981a6_50c636d4 PS1, Line 253: u32 reserved : 17; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/d6aa2b4a_4a5aa0b5 PS1, Line 253: u32 reserved : 17; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/e32736e3_38119587 PS1, Line 254: }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/0172e54b_4a8cdf11 PS1, Line 255: u32 hart_index; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ae35de78_e18651cc PS1, Line 260: struct { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/375dae43_16058072 PS1, Line 261: u64 mmu_type : 4; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/6e56daea_dd1c6cec PS1, Line 261: u64 mmu_type : 4; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ba2dfe15_afb2f1de PS1, Line 262: u64 aia_enabled : 1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/84bfadc8_84dfb2df PS1, Line 262: u64 aia_enabled : 1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ed122753_e0f65282 PS1, Line 263: u64 reserved : 59; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/18be0cb7_342164a9 PS1, Line 263: u64 reserved : 59; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/6ea5781a_72cf3f00 PS1, Line 264: }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/9853fd06_1cb3b097 PS1, Line 265: u64 hart_cap; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/fa02b7c1_b8fa825e PS1, Line 272: u16 reserved; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/a81bbbac_d959b789 PS1, Line 273: u32 flags; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/32b65db1_b9689c9a PS1, Line 274: u32 parent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/1c45b044_892e5889 PS1, Line 275: u32 acpi_processor_id; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/220301cd_57b730dd PS1, Line 276: u32 num_private_resources; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/09ce371c_80c46b76 PS1, Line 277: u32 private_resources[]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/b4992dc4_d1d8cb72 PS1, Line 283: u16 reserved; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/24cbeb89_8590c02c PS1, Line 284: u32 flags; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/01167457_ed8c23ec PS1, Line 285: u32 next_level_cache; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/994a92b4_2e181e87 PS1, Line 286: u32 size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/d9fc6354_db3e0224 PS1, Line 287: u32 num_sets; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/70228f42_4e4a170e PS1, Line 288: u8 associativity; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/1d5e704a_10063646 PS1, Line 296: u16 version; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/26cc4d3f_241ab9cb PS1, Line 303: u64 imsic_addr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/9f8dd14d_90341710 PS1, Line 304: u32 imsic_size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/b50806fb_720be72f PS1, Line 305: u32 num_harts; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/dad71831_5357fbee PS1, Line 306: u8 cpuId[]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/b6ba1206_53cb6a76 PS1, Line 311: u8 type; \ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/09643c7b_1df40dc5 PS1, Line 311: u8 type; \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/85ff564d_968b867f PS1, Line 312: u8 length; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/686e83bc_9d0d231c PS1, Line 313: u8 id; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/f4f04a24_b5b62c8b PS1, Line 314: u8 version; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/1006e720_645bebdc PS1, Line 315: u8 mode; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/682f0f1b_522cec00 PS1, Line 316: u8 num_sockets; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/fbf95226_9509bf94 PS1, Line 317: u16 total_num_harts; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/d29bc7c1_01c45e37 PS1, Line 318: u16 num_interrupt_id; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/3c94be06_99a491f7 PS1, Line 319: u16 ext_irq_num; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ecc18dc1_50a87a27 PS1, Line 320: u16 ipi_base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/08641b3e_dece443f PS1, Line 321: u16 ipi_count; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/3cc80ec1_08b07e65 PS1, Line 322: u32 hart_index; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/4da23ceb_527d7ad6 PS1, Line 323: u32 reserved2; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/3e006b9d_2d2dc2e4 PS1, Line 324: AcpiImsicSocket socket_imsic[]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/6fd9e77b_78843bb6 PS1, Line 329: u64 imsic_addr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/c942026e_c0375221 PS1, Line 330: u32 hart_index; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/0ea5aa6e_257257a6 PS1, Line 331: u16 imsic_size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/54647cfa_91d6f6fa PS1, Line 332: u16 num_harts; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/cbc94d8d_09e1d6a8 PS1, Line 333: u8 cpuId[]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/01f23e84_31edc36d PS1, Line 338: u8 type; \ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/0e01ac50_8a64c986 PS1, Line 338: u8 type; \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/7e0e83fd_bc547e5c PS1, Line 339: u8 length; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/a5562c97_695fcbd4 PS1, Line 340: u16 global_irq_base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/81d490d7_84ae0320 PS1, Line 341: u16 mode; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/fe222766_cec6280a PS1, Line 342: u16 id; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/8195c0e7_76bb2972 PS1, Line 343: u16 num_interrupts; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/9ac4ecc8_3eb6280f PS1, Line 344: u16 target_imsic; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ae88d6d5_3ee069a5 PS1, Line 345: u16 reserved; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/536be43e_915e66b1 PS1, Line 346: u16 aplic_size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/2146019d_2113862b PS1, Line 347: u64 aplic_addr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/c24a6b23_1bb05fae PS1, Line 348: AcpiAplicImsicInfo imsic_info; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/f6afe02c_98f9ba03 PS1, Line 353: u8 type; \ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ee660e5e_80521ee5 PS1, Line 353: u8 type; \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/b78c50fe_1dd947d1 PS1, Line 354: u8 length; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/f44ab135_1290b247 PS1, Line 355: u8 version; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ffb26f3e_3447489f PS1, Line 356: u8 aia_csr_enabled; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/f70c5e79_dff2d69b PS1, Line 357: u32 acpi_proc_id; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/de26e75b_a7266136 PS1, Line 358: struct Acpi128 hartId; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/6007e709_304e5386 PS1, Line 366: u16 num_mtimer; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/79f8da18_fabe369c PS1, Line 367: u16 num_harts; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/b996767e_5aded49d PS1, Line 368: u32 reserved1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/f9e482fb_1e9ea698 PS1, Line 369: u32 size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/ac03ad26_615fcada PS1, Line 370: u64 base_addr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/95311338_4c03720c PS1, Line 371: u64 time_base_frequency; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175115): https://review.coreboot.org/c/coreboot/+/74808/comment/50ecd829_15ff7c83 PS1, Line 372: struct Acpi128 hartId[]; please, no spaces at the start of a line