Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56450 )
Change subject: soc/amd/picasso: Move IVRS generation code to common ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
I'd introduce the Kconfig option SOC_AMD_COMMON_BLOCK_ACPI_IVRS here and only select that in picasso […]
done
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/56450/comment/f9615aa4_cd0d779e PS1, Line 1202: acpi_populate_ivrs
acpi_fill_ivrs would be more consistent with the existing functions here
Done
File src/soc/amd/common/block/acpi/ivrs.c:
https://review.coreboot.org/c/coreboot/+/56450/comment/01fbcb6f_c578273f PS1, Line 356: /* BDF <bus>:00.2 */ : ivrs->ivhd.device_id = 0x02 | (nb_dev->bus->secondary << 8); : ivrs->ivhd.capability_offset = pci_find_capability(iommu_dev, IOMMU_CAP_ID); : ivrs->ivhd.iommu_base_low = pci_read_config32(iommu_dev, 0x44) & 0xffffc000; : ivrs->ivhd.iommu_base_high = pci_read_config32(iommu_dev, 0x48);
It could be in a follow-on, but something like this could potentially change across generations of A […]
Agree