Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33381 )
Change subject: nb/intel/nehalem: Tidy quickpath_reserved calculation
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33381/1/src/northbridge/intel/nehalem/ramini...
File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/#/c/33381/1/src/northbridge/intel/nehalem/ramini...
PS1, Line 1442: (u32)1
I've usually seen '1UL' or '1ULL'
I've also seen those, but their widths depend on the target architecture. Currently 1UL would also work since sizeof(unsigned long) == 32, but there is no guarantee this will stay that way in the future, so I prefer explicit widths.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8651f8cd04165d8d31c44f7919ad5e43499d3d4c
Gerrit-Change-Number: 33381
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Jun 2019 19:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment