Attention is currently required from: Johannes Hahn, Mario Scheithauer, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80186?usp=email )
Change subject: mb/siemens/mc_ehl3: Use PSE GbE 0 instead of PSE GbE 1
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80186/comment/ec117cc5_800a1b9d :
PS1, Line 10: 1
0
Done
File src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c:
https://review.coreboot.org/c/coreboot/+/80186/comment/7be8f399_9102e2b4 :
PS1, Line 111: PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), /* PSE_GBE0_AUXTS */
: PAD_CFG_NF(GPP_C7, NONE, DEEP, NF1), /* PSE_GBE0_PPS */
I think C6 and C7 belong to GBE1. You should be able to set both to NC.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80186?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I322371f944d15134e6f48ecd84a4026c2fced27b
Gerrit-Change-Number: 80186
Gerrit-PatchSet: 2
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 26 Jan 2024 10:06:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-MessageType: comment