Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31135 )
Change subject: mainboard/google/octopus/variants/casta: Correct unused GPIO pad configuration ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patch Set 1: Code-Review+1
(1 comment)
Tested how? Any visible effects?
Reading register address "0xD0C508E0" using iotools command should produce the following output: 0x40000402
https://review.coreboot.org/#/c/31135/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31135/1//COMMIT_MSG@7 PS1, Line 7: mainboard/google/octopus/variants/casta: Correct unused GPIO pad configuration
Please use *mb* instead of *mainboard* to make it shorter.
Also "variants" can be removed. That will make it shorter i.e. mb/google/octopus/casta: Correct unused GPIO pad configuration