Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37451 )
Change subject: AGESA,binaryPI: Move PORT80 selection to C bootblock
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37451/7/src/mainboard/asrock/imb-a1...
File src/mainboard/asrock/imb-a180/romstage.c:
https://review.coreboot.org/c/coreboot/+/37451/7/src/mainboard/asrock/imb-a1...
PS7, Line 34: /* Set LPC decode enables. */
Another point to remove in the near future. Other boards may as well have these LPC and ACPI MMIO decode-enables. To be revisited.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37451
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71aa94b33bd6f65e243724810472a440e98e0750
Gerrit-Change-Number: 37451
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 08 Dec 2019 21:48:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment