Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/...
PS1, Line 13: DRIVERS_UART_ACPI
no, that's independent of that setting. […]
Ack
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/...
PS1, Line 14: PICASSO_CONSOLE_UART
One of the UARTs can be switched to legacy mode; see CB:40322 […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa66657b88f62b2067c865c3e1945b7bdbf9be23
Gerrit-Change-Number: 44529
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Aug 2020 08:18:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment