[coreboot-gerrit] Change in coreboot[master]: inteltool: Support dumping IOBP register values

[Iru Cai (vimacs) (Code Review)]

Attention is currently required from: Angel Pons.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41473 )

Change subject: inteltool: Support dumping IOBP register values
......................................................................

Patch Set 18:

(3 comments)

File util/inteltool/iobp.c:

https://review.coreboot.org/c/coreboot/+/41473/comment/2054c2cd_b95027c1 
PS17, Line 8: ,
> nit: space after the comma (same for RCBA32)

Done

https://review.coreboot.org/c/coreboot/+/41473/comment/02d97764_963162da 
PS17, Line 76: char *
> should be `const char *`, which means "pointer to `const char`"

Done

https://review.coreboot.org/c/coreboot/+/41473/comment/095849af_4c6ea8f4 
PS17, Line 74: typedef struct {
             : 	u32 addr;
             : 	char *name;
             : } iobp_register_t;
> Is a typedef really needed? […]

Not needed, but the following array definitions will have one more "struct" like "struct iobp_register" without using typedef. And other files in inteltool also use typedef like io_register_t, msr_entry_t.