Attention is currently required from: Raul Rangel, Reka Norman, Nick Vaccaro, Karthik Ramasubramanian.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62905 )
Change subject: util/spd_tools: Add support for exclusive IDs
......................................................................
Patch Set 7:
(2 comments)
File util/spd_tools/src/part_id_gen/part_id_gen.go:
https://review.coreboot.org/c/coreboot/+/62905/comment/a37c9ee6_e1ae2484
PS5, Line 332: &&
From consistency standpoint, can we add Exclusive entries to SPDToIndexMap. […]
Unfortunately this wouldn't result in the right behavior. If an exclusive entry is present in SPDToIndexMap then the auto-assigning code will continue through line 384 resulting in the part at that index getting overwritten. Additionally, attempting to use both Fixed and Exclusive with the same slot is an error.
https://review.coreboot.org/c/coreboot/+/62905/comment/b33bb494_7ee84486
PS5, Line 359: if index < len(assignedMapping) {
: mapping = assignedMapping[index]
: }
This check can be removed if you append assignedMapping after line 385: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife5afe32337f69bc06451ce16238c7a83bc983c8
Gerrit-Change-Number: 62905
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sat, 19 Mar 2022 00:08:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment