Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41885 )
Change subject: dptf: Add support for generation of Active Policies
......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41885/10/src/acpi/acpigen_dptf.c
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/41885/10/src/acpi/acpigen_dptf.c@8
PS10, Line 8: #define GNVS_DPTE "\DPTE"
I think this should be unused now.
Done
https://review.coreboot.org/c/coreboot/+/41885/10/src/drivers/intel/dptf/dpt...
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41885/10/src/drivers/intel/dptf/dpt...
PS10, Line 36: it's
its?
Done
https://review.coreboot.org/c/coreboot/+/41885/10/src/include/acpi/acpigen_d...
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/41885/10/src/include/acpi/acpigen_d...
PS10, Line 36: /* */
Nit: empty comment. Probably missing explanation for weight.
Oops yep, that's it. Will fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea0ccbd96f88d0f3a8f2c77a7d0f3a284e5ee463
Gerrit-Change-Number: 41885
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 02:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment