Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30809 )
Change subject: mb/google/hatch: Use USB2 Port 10 for BT over CnVi ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 93: device usb 0.0 on
Why was this not updated to reflect the change for usb port for cnvi bt?
I have to include that code, I did not add it to this CL , since did not test those changes in PO. I have created a bug to track it. https://partnerissuetracker.corp.google.com/issues/123375275
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 118: chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.4 on end : end
Also, it means that this description is not correct when using CNVI BT. […]
Ok. Since these are entries communicating individual port capabilities I do not see a conflict. Even if both Ports expose connection type as Bluetooth and non-connectable it would hold true since we are not using those ports externally. For the next board spin the USB2 P10 would be routed to M,2 connector. So we could remove the USB2 P5 entry and disable it.But this would get the discrete BT to not work on proto. https://partnerissuetracker.corp.google.com/issues/122552619
Please let me know on your thoughts.