[coreboot-gerrit] Change in coreboot[master]: [WIP] sb/amd/pi/hudson: Fixes for common GPIO API

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42733 )

Change subject: [WIP] sb/amd/pi/hudson: Fixes for common GPIO API
......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42733/8/src/southbridge/amd/pi/huds... 
File src/southbridge/amd/pi/hudson/soc/smi.h:

PS8:
> for everything apart from the defines soc/amd/common/block/include/amdblocks/smi. […]

I think it was the same question as with <soc/gpio.h>, how should the #includes look like when the tree is organized as discrete cpu/ nb/ sb/ directories.

https://review.coreboot.org/c/coreboot/+/42733/8/src/southbridge/amd/pi/huds... 
PS8, Line 4: #define __SOC_SMI_H__
Drop __

https://review.coreboot.org/c/coreboot/+/42733/8/src/southbridge/amd/pi/huds... 
PS8, Line 7: /* FIXME: Copies from stoneyridge now. */
Resolve before merge