Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42094 )
Change subject: amd/00730F01: Clean the Microcode updating. ......................................................................
Patch Set 3: Code-Review-2
(1 comment)
The patch should ADD the support for Picasso and family 17h on top of existing infrastructure, NOT break behavior for older family and add support for Picasso on top of that.
https://review.coreboot.org/c/coreboot/+/42094/3/src/cpu/amd/pi/00730F01/upd... File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/42094/3/src/cpu/amd/pi/00730F01/upd... PS3, Line 17: { 0x730f01, 0x7301 }, Why do you remove support for family 16h?! This is src/cpu/amd/pi/00730F01/update_microcode.c for CPU models 00730F01. I have contributed this code so that the users of PC Engines apu2 (binaryPI 00730F01) could update their microcode: https://github.com/pcengines/apu2-documentation/issues/75