Shelley Chen has posted comments on this change. ( https://review.coreboot.org/25028 )
Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants/... PS1, Line 72: 8
Don't you need this to be 9?
Oh sorry. I forgot the null termination. Thanks.