Attention is currently required from: Kangheui Won, Paul Fagerburg, Shou-Chieh Hsu.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64045 )
Change subject: util/mb/google: add support for nissa
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
Looks good, but it would be good to test it. This should be covered by running new_variant_fulltest, right?
File util/mainboard/google/nissa/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/64045/comment/b39a0bfa_d34a91f9
PS1, Line 5: placeholder
Have you tested that we can build a new variant with this template? I think this will cause make to […]
This should be fine, it's what we've been doing on other boards. See CB:57795.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04f75ff91f9851b82641f703ba950b04c22e2e72
Gerrit-Change-Number: 64045
Gerrit-PatchSet: 1
Gerrit-Owner: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Thu, 05 May 2022 01:19:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment