Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )
Change subject: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY ......................................................................
Patch Set 7:
(1 comment)
Patch Set 5:
What does FSP do if we set it to PRIMARY_PCI but there is no gfx card plugged in?
In this case, IGD should be used, since this option set the priority device only. Unfortunately, I can not test this with Appollo Lake CPU, because my board doesn't have the necessary connectors, but it was tested on the boards with Skylake (CB:32044).
https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... File src/soc/intel/apollolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... PS7, Line 259: PrimaryVideoAdaptor
What does it do and why is it needed?
I suppose that it is necessary to select an active graphics device https://github.com/intel/FSP/blob/dd34b8c451a23c62a972419287021abfb7d01c2d/A...
In the case of Skylake (See CB:32172), when Display_PEG was selected, Linux was output to an external graphics device. At the same time, IGD was also enabled.