Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74846 )
Change subject: soc/amd/common/block/lpc/lpc: use mmio_range to report FCH IOAPIC MMIO ......................................................................
soc/amd/common/block/lpc/lpc: use mmio_range to report FCH IOAPIC MMIO
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I813a27e392a842188dc474018f82e10309783260 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74846 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/amd/common/block/lpc/lpc.c 1 file changed, 15 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index edc7476..43b3791 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -126,10 +126,8 @@ /* Add a memory resource for the eSPI MMIO */ mmio_range(dev, 3, SPI_BASE_ADDRESS + ESPI_OFFSET_FROM_BAR, 4 * KiB);
- res = new_resource(dev, 4); /* IOAPIC */ - res->base = IO_APIC_ADDR; - res->size = 0x00001000; - res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; + /* FCH IOAPIC */ + mmio_range(dev, 4, IO_APIC_ADDR, 4 * KiB);
compact_resources(dev); }