Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33431 )
Change subject: TEMP: NOT FOR REVIEW: google/mistral: Add LED calibration ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
not a huge fan of duplication like that, but it's the most pragmatic approach. thanks!
https://review.coreboot.org/#/c/33431/3/src/mainboard/google/mistral/led_cal... File src/mainboard/google/mistral/led_calibration.c:
https://review.coreboot.org/#/c/33431/3/src/mainboard/google/mistral/led_cal... PS3, Line 53: _strspn please move the string manipulation functions to src/lib/string.c (which is also built for verstage, hence available), without the leading underscore.