Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44002 )
Change subject: mb/google/kahlee: Set EFS SPI platform configuration
......................................................................
Patch Set 2:
I have refactored the change as follows.
1. Kconfig changes
2. Build changes for picasso platforms
3. Build changes for stoney ridge platforms
An optional future 4th change would be to address the duplicate definition of this information in
mainboard/google/kahlee/bootblock/bootblock.c
mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb
mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b979d79ad2dc920e8baf288ddfab04f04f42789
Gerrit-Change-Number: 44002
Gerrit-PatchSet: 2
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 Jul 2020 17:08:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment