Attention is currently required from: Paul Menzel, Richard Marko.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78415?usp=email )
Change subject: util/kconfig: chmod +w before savedefconfig ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2: Hi Richard, It looks like you haven't contributed to the coreboot project before.
Welcome, and thank you for the patch. We hope that this is just the first of many.
Please let us know if there's anything we can do to help get your first sets patches merged as you get used to the contribution process.
The coreboot project has a hands-off policy regarding other people's patches so nobody here is going to update the contents without your permission. If you would you like someone to take over your patches at any point, please just post a comment to that effect on the specific patch.
You might find the coding style guide and the gerrit guidelines useful to read.
https://doc.coreboot.org/contributing/coding_style.html https://doc.coreboot.org/contributing/gerrit_guidelines.html
If you want to talk with anyone, you can talk to developers on one of the many options we have:
https://doc.coreboot.org/community/forums.html Again, please let us know if you have any questions, or if there's anything we can do to help.
Martin
File util/kconfig/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78415/comment/3acb01a4_ffc81b08 : PS2, Line 37: chmod +w $(DEFCONFIG) Could you add a comment above the target name 'savedefconfig:' saying why this was added, then add a "quilt compatible" .patch file with this change to the util/kconfig/patches directory so that your change doesn't get lost the next time we update to a new version of Kconfig?
Basically, we store all of our updates as .patch files so that we can just pull a new Kconfig version from kernel.org, then apply the patches on top of the new version.
You can look at the history of the kconfig/patches directory for hints.
Thanks for the patch.