Nico Huber has posted comments on this change. ( https://review.coreboot.org/27168 )
Change subject: inteltool: Add PCI IDs for the C220 PCH series ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/27168/7/util/inteltool/gpio.c File util/inteltool/gpio.c:
https://review.coreboot.org/#/c/27168/7/util/inteltool/gpio.c@873 PS7, Line 873: /* Shares Lynx Point register locations but has less of them */ Nit, all 8 series is Lynx Point. The integrated one is referred to as Lynx Point-LP.
https://review.coreboot.org/#/c/27168/7/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/#/c/27168/7/util/inteltool/inteltool.h@187 PS7, Line 187: #define PCI_DEVICE_ID_INTEL_C8_MOBILE 0x8c41 : #define PCI_DEVICE_ID_INTEL_C8_DESKTOP 0x8c42 These two use spaces now?