[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common: Support power limits update for variants

[Sumeet R Pawnikar (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal.

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74620 )

Change subject: soc/intel/common: Support power limits update for variants
......................................................................

Patch Set 7:

(3 comments)

File src/soc/intel/common/block/power_limit/power_limit.c:

https://review.coreboot.org/c/coreboot/+/74620/comment/936c588b_8210243c 
PS7, Line 248: config
> should we check if dptf is enabled ?

Done

https://review.coreboot.org/c/coreboot/+/74620/comment/6c0a380e_f3c44ab7 
PS7, Line 250: mch_id
> if the mch is 0xffff? shouldn't we bail out ?

Ack

https://review.coreboot.org/c/coreboot/+/74620/comment/0b73d381_5a771204 
PS7, Line 255: 	if (mch_id == limits[i].mch_id && tdp == limits[i].cpu_tdp) {
> can we check the negative case and continue ? that was you save one tab in all below lines 😊

Ack