Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42094 )
Change subject: amd/00730F01: Clean the Microcode updating.
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42094/3/src/cpu/amd/pi/00730F01/upd...
File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/42094/3/src/cpu/amd/pi/00730F01/upd...
PS3, Line 17: { 0x730f01, 0x7301 },
Why do you remove support for family 16h?! This is src/cpu/amd/pi/00730F01/update_microcode.c […]
Done. Sorry, I mixed up with picasso patch. Now we get rid of the table and use bitwise check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42094
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0da99db0d3189058f75e199f05492c4e6c5881
Gerrit-Change-Number: 42094
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 05 Jun 2020 10:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment