[coreboot-gerrit] [XL] Change in coreboot[main]: lib/jpeg: Replace decoder with Wuffs' implementation

[Nigel Tao (Code Review)]

Attention is currently required from: Martin L Roth, Patrick Georgi, Tim Wawrzynczak.

Nigel Tao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78271?usp=email )

Change subject: lib/jpeg: Replace decoder with Wuffs' implementation
......................................................................

Patch Set 2:

(1 comment)

File src/lib/bootsplash.c:

https://review.coreboot.org/c/coreboot/+/78271/comment/bf59ab9f_96634524 :
PS2, Line 29: 	printk(BIOS_DEBUG, "Bootsplash image resolution: %dx%d\n", image_width, image_height);
> pass the `image_width > x_resolution` check

Ah, actually it won't. I mis-remembered how C implicitly converts signed/unsigned in "a < b" expressions, when a and b have different types.

Still, mixing signed and unsigned can obviously be confusing / surprising / buggy, and I'd recommend being explicit. And, y'know, returning early if `jpeg_fetch_size` fails.