Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37995 )
Change subject: mainboard/asus/p10s-series: Initial port to ASUS P10S-I ......................................................................
Patch Set 9: Code-Review+1
(9 comments)
https://review.coreboot.org/c/coreboot/+/37995/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37995/3//COMMIT_MSG@10 PS3, Line 10: P10S-M
Probably not. […]
Ack. Turning a regular board into a variant-enabled setup is rather easy.
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... PS9, Line 23: This is a string, it doesn't need to look like a Kconfig symbol
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... PS9, Line 28: This can be added when the respective boards are ported. Currently, it's dead code
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/bootblock.c:
PS9: Missing a few things here, check other boards to find additional things to put here
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/variants/p10s-i/include/variant/gpio.h:
PS3:
I didn't. This is inherited verbatim from the Supermicro board I'm basing this on. […]
Would be nice if you could put this script somewhere, so that others can use it. Even if it's an ugly hack, it won't be worse than hswgpio.c on my github :D
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/variants/p10s-i/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... PS9, Line 230: The current entries look good. Maybe also add the SMBus pads because you have to read SPDs off the DIMMs.
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/variants/p10s-m/board_info.txt:
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... PS9, Line 30: Ǹote: these are PCIe root ports. What they are connected to depends on the mainboard. In the case of M.2, it's very likely that CLKREQ# is used.
https://review.coreboot.org/c/coreboot/+/37995/9/src/mainboard/asus/p10s-ser... PS9, Line 39: lsusb might help
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/variants/p10s-m/include/variant/gpio.h:
PS3:
I didn't. This is inherited verbatim from the Supermicro board I'm basing this on. […]
Ack