Patch set 9:Code-Review +1
9 comments:
Patch Set #3, Line 10: P10S-M
Probably not. […]
Ack. Turning a regular board into a variant-enabled setup is rather easy.
File src/mainboard/asus/p10s-series/Kconfig.name:
This is a string, it doesn't need to look like a Kconfig symbol
This can be added when the respective boards are ported. Currently, it's dead code
File src/mainboard/asus/p10s-series/bootblock.c:
Missing a few things here, check other boards to find additional things to put here
File src/mainboard/asus/p10s-series/variants/p10s-i/include/variant/gpio.h:
I didn't. This is inherited verbatim from the Supermicro board I'm basing this on. […]
Would be nice if you could put this script somewhere, so that others can use it. Even if it's an ugly hack, it won't be worse than hswgpio.c on my github :D
File src/mainboard/asus/p10s-series/variants/p10s-i/overridetree.cb:
The current entries look good. Maybe also add the SMBus pads because you have to read SPDs off the DIMMs.
File src/mainboard/asus/p10s-series/variants/p10s-m/board_info.txt:
Ǹote: these are PCIe root ports. What they are connected to depends on the mainboard. In the case of M.2, it's very likely that CLKREQ# is used.
lsusb might help
File src/mainboard/asus/p10s-series/variants/p10s-m/include/variant/gpio.h:
I didn't. This is inherited verbatim from the Supermicro board I'm basing this on. […]
Ack
To view, visit change 37995. To unsubscribe, or for help writing mail filters, visit settings.