Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31331 )
Change subject: mb/google/sarien/variants/arcada: Update thermal configuration for DPTF
......................................................................
Patch Set 2:
(1 comment)
Please check the comment.
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/dptf.asl:
https://review.coreboot.org/#/c/31331/2/src/mainboard/google/sarien/variants...
PS2, Line 23: 108
If intention here to prevent any high temperature serious issue, in that case, you should set this c […]
The thermal sensor is built on MB (have distance from casing) and due to different location it will have different heat shock. If it locate nearby CPU, value lower than 100 degree will easily be triggered when CPU turbo.
This value is based on Bandon (leading Windows project) setting, for Arcada, we will fine tune the value at the next stage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieed8021b83776fdb6320ff89b57c8d2747667fd5
Gerrit-Change-Number: 31331
Gerrit-PatchSet: 2
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 15 Feb 2019 03:16:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Casper Chang
casper_chang@wistron.corp-partner.google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment