[coreboot-gerrit] Change in coreboot[master]: treewide: Remove unused spinlock functions

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Nico Huber, Marshall Dawson, Julius Werner, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59020 )

Change subject: treewide: Remove unused spinlock functions
......................................................................

Patch Set 2:

(1 comment)

File src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h:

https://review.coreboot.org/c/coreboot/+/59020/comment/88797029_7f6a166c 
PS2, Line 8: #define spin_unlock(lock)	do {} while (0)
> We could change the guard to `CONFIG(SMP) && ENV_RAMSTAGE`.

You can't have <smp/spinlock.h> make assumptions about which arch supports spinlocks in which stages. There were suggestion made in CB:43310 commentary on which people fast-tracking the critized workaround did not react to clean it up.

Can you get answers why CB:47650 was abandoned and what the real reason for CB:43310 was. I was only told it was regression related to Chromium trees that was not triggered with upstream jenkins so it was fast-tracked in. Less to discuss if we can just throw away this file now completely. I would have fixed this by now if there were decent answers given.