Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37946 )
Change subject: kontron/986lcd-m: use common winbond/nuvoton HWM bank select function ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37946/1/src/mainboard/kontron/986lc... File src/mainboard/kontron/986lcd-m/Kconfig:
https://review.coreboot.org/c/coreboot/+/37946/1/src/mainboard/kontron/986lc... PS1, Line 11: select SUPERIO_NUVOTON_COMMON_HWM
can't we move this to 'src/superio/winbond/w83627thg/Kconfig' ?
I selected this in the mainboard's Kconfig file and not in the SIO's Kconfig file, since the SIO code doesn't use the function that gets linked by selecting this symbol, but the mainboard code does. If the SIO code used this, then the SIO's Kconfig should select this, but this isn't the case here (yet?)