[coreboot-gerrit] Change in coreboot[master]: arch/x86/acpigen: Add helpers for generating _ADR

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40670 )

Change subject: arch/x86/acpigen: Add helpers for generating _ADR
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40670/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40670/3//COMMIT_MSG@10 
PS3, Line 10: acpigen_write_ADR: Generates _ADR object using provided 64-bit address
> This doesn't match anything in my understanding of ACPI. Can you give […]

ACPI specification version 6.3 section 6.1.1 says that _ADR is an "integer" containing the address of the device. Integer is represented as 64-bits since ACPI 2.0.

Also, relevant change for kernel: https://patchwork.kernel.org/patch/10901037/