Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37620 )
Change subject: soc/intel/cannonlake: Make Heci configurable
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37620/6/src/soc/intel/cannonlake/ch...
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37620/6/src/soc/intel/cannonlake/ch...
PS6, Line 233: uint8_t HeciEnabled;
it's already here, why do you need to add it again?
I cant find it... where is it already?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa5b1440b4d6622cef0bfe82dc22a81b55f12bda
Gerrit-Change-Number: 37620
Gerrit-PatchSet: 6
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Dec 2019 15:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment