Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37867 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM)
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37867/11/src/ec/google/chromeec/ec....
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/37867/11/src/ec/google/chromeec/ec....
PS11, Line 1542: /**
: * Check for the current mux state in EC
: * Flags representing mux state
: * USB_PD_MUX_USB_ENABLED BIT(0)
: * USB_PD_MUX_DP_ENABLED BIT(1)
: * USB_PD_MUX_POLARITY_INVERTED BIT(2)
: * USB_PD_MUX_HPD_IRQ BIT(3)
: * USB_PD_MUX_HPD_LVL BIT(4)
: * USB_PD_MUX_SAFE_MODE BIT(5)
: *
: */
this is a copy of what's in ec_commands.h, right? […]
case in point: it's already out of sync from master :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96bfb6036f4340ba42a078cfd7ecaae777a3ed00
Gerrit-Change-Number: 37867
Gerrit-PatchSet: 11
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Comment-Date: Wed, 05 Feb 2020 03:44:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: caveh jalali
caveh@chromium.org
Gerrit-MessageType: comment