Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47308 )
Change subject: mb/google/zork: Init fingerprint GPIOs for boot vs resume ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... PS7, Line 302: ) I think this should be done only when slp_typ is not ACPI_S3?
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... PS7, Line 29: powering on because of reset, powering on, or resuming from S3 That is the case for all GPIOs, right? Probably add GPIOs that need to be configured early on in bootblock?