Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37683 )
Change subject: arch/x86: Fix S3 resume without stage cache
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37683/7/src/arch/x86/postcar_loader...
File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/37683/7/src/arch/x86/postcar_loader...
PS7, Line 240: if (prog_entry(&prog) == NULL)
Am I correct that this logic is assuming prog_entry(&prog) == NULL under these conditions? […]
With the Kconfig change I don't really need to touch this at all.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0da3e1cf4c92817ffabbb02eda3476ecdfdfa278
Gerrit-Change-Number: 37683
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Dec 2019 18:26:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment