Attention is currently required from: Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85816?usp=email )
Change subject: drivers/asmedia: Add code to enable AHCI for ASM1061
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/drivers/asmedia/asm1061.c:
https://review.coreboot.org/c/coreboot/+/85816/comment/b35f0734_6fb3d426?usp... :
PS5, Line 40: 0x0611, /* ASM1061 SATA IDE Controller */
Yes, the device ID changes from 0x611 to 0x0612 after the subclass code register is written.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85816?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23
Gerrit-Change-Number: 85816
Gerrit-PatchSet: 5
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sun, 19 Jan 2025 11:56:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com