Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45789 )
Change subject: soc/intel: Move pch_misc_init() to common code
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45789/11/src/soc/intel/common/block...
File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/45789/11/src/soc/intel/common/block...
PS11, Line 15:
:
: #define PPI_PORT_B 0x61
: #define SERR_DIS (1 << 2)
: #define CMOS_NMI 0x70
: #define NMI_DIS (1 << 7)
nit: move these next to the function using them. Otherwise, one needs to scroll up hundreds of lines to see what they mean.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie36ee63869c076d251ccfa5409001d18f22600d7
Gerrit-Change-Number: 45789
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 14:08:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment