Mengqi Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32460 )
Change subject: mediatek/mt8183: Add SPI GPIO driving setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/mt8183.c
File src/soc/mediatek/mt8183/mt8183.c:
https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/mt8183.c@23
PS2, Line 23: gpio_set_spi_driving();
I'm probably fine if this is set only after verstage if that helps reducing bootblock size. […]
I'm trying to reduce the code size, please review the latest patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95002ec71abd751c33c089185db04ed4a8686699
Gerrit-Change-Number: 32460
Gerrit-PatchSet: 2
Gerrit-Owner: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 May 2019 13:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment