Attention is currently required from: Kevin Chiu, Furquan Shaikh, Robert Chen, Tim Wawrzynczak, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57828 )
Change subject: mb/google/dedede/var/kracko: refactor DPTF section for overrides
......................................................................
Patch Set 10: Code-Review+2
(3 comments)
File src/mainboard/google/dedede/variants/kracko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57828/comment/10650ef4_dc88808e
PS3, Line 122: register "desc" = ""Multi-use Port""
: register "type" = "UPC_TYPE_A"
why changes this?
Done
https://review.coreboot.org/c/coreboot/+/57828/comment/57512635_4dd93ee6
PS3, Line 155: register "desc" = ""Multi-use Port""
: register "type" = "UPC_TYPE_USB3_A"
why changes this?
Done
File src/mainboard/google/dedede/variants/kracko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57828/comment/5ba61aa2_bd887816
PS5, Line 115:
`alias dptf_policy`: https://review.coreboot. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacc543f961a7f4652ee8583920b1794f916c7ec9
Gerrit-Change-Number: 57828
Gerrit-PatchSet: 10
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 24 Sep 2021 17:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Chiu
kevin.chiu.17802@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment