Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46435 )
Change subject: cpu/x86/mtrr: add support for address space higher than 16TiB
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46435/7/src/cpu/x86/mtrr/mtrr.c
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/46435/7/src/cpu/x86/mtrr/mtrr.c@487
PS7, Line 487: mtrr_size = 1 << size_msb;
We need to make these 1ULL as well […]
Sorry for missing this. I submitted [CB:46711].
https://review.coreboot.org/c/coreboot/+/46435/7/src/cpu/x86/mtrr/mtrr.c@489
PS7, Line 489: mtrr_size = 1 << addr_lsb;
** CID 1435825: Integer handling issues (OVERFLOW_BEFORE_WIDEN) […]
Sorry for missing this. I submitted [CB:46711].
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46435
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41bc5befcc1374c838c91b9f7c5279ea76dd67c7
Gerrit-Change-Number: 46435
Gerrit-PatchSet: 7
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 23 Oct 2020 22:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment