Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42205 )
Change subject: mb/google/dedede: Add ACPI support for camera in WDee
......................................................................
Patch Set 19:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded...
PS19, Line 136: 15.3 on # I2C 3
As ren points out in https://buganizer.corp.google. […]
I notice Ren also had a hunk to light up i2c5 in general:
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
index 363307b0db..0eb77ffd8f 100644
--- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb
@@ -45,7 +45,7 @@ chip soc/intel/jasperlake
[PchSerialIoIndexI2C2] = PchSerialIoPci,
[PchSerialIoIndexI2C3] = PchSerialIoPci,
[PchSerialIoIndexI2C4] = PchSerialIoPci,
- [PchSerialIoIndexI2C5] = PchSerialIoDisabled,
+ [PchSerialIoIndexI2C5] = PchSerialIoPci,
}"
register "SerialIoGSpiMode" = "{
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f6b490832d2c34c86512384eb7470f13a212a66
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 19
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kaiyen Chang
kaiyen.chang@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evan Green
evgreen@chromium.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-CC: Tomasz Figa
tfiga@google.com
Gerrit-Comment-Date: Tue, 15 Sep 2020 16:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evan Green
evgreen@chromium.org
Gerrit-MessageType: comment