build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29897 )
Change subject: util/inteltool: Add Apollo Lake GPIO groups and names ......................................................................
Patch Set 4:
(28 comments)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c File util/inteltool/gpio_groups.c:
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@108 PS4, Line 108: "*GPIO_72", "GP_CAMERASB10","n/a", "n/a", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@109 PS4, Line 109: "*GPIO_73", "GP_CAMERASB11","n/a", "n/a", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@116 PS4, Line 116: "JTAGX" , "*JTAGX", "n/a", "n/a", "n/a", "n/a", space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@123 PS4, Line 123: "SVID0_ALERT_B","*SVID0_ALERT_N","n/a", "n/a", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@123 PS4, Line 123: "SVID0_ALERT_B","*SVID0_ALERT_N","n/a", "n/a", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@167 PS4, Line 167: "PMC_SPI_FS2", "*PMC_SPI_FS2", "FST_SPI_CS2_N","n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@181 PS4, Line 181: "*GPIO_74", "AVS_I2S1_MCLK" , "n/a", "n/a", space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@186 PS4, Line 186: "*GPIO_79", "AVS_DMIC_CLK_A1", "AVS_I2S4_BCLK","n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@187 PS4, Line 187: "*GPIO_80", "AVS_DMIC_CLK_B1", "AVS_I2S4_WS_SYNC","n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@191 PS4, Line 191: "*GPIO_84", "AVS_I2S2_MCLK", "AVS_HDA_RST_N","n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@319 PS4, Line 319: "*GPIO_134", "LPSS_I2C5_SDA","ISH_I2C0_SDA", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@320 PS4, Line 320: "*GPIO_135", "LPSS_I2C5_SCL","ISH_I2C0_SCL", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@321 PS4, Line 321: "*GPIO_136", "LPSS_I2C6_SDA","ISH_I2C1_SDA", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@322 PS4, Line 322: "*GPIO_137", "LPSS_I2C6_SCL","ISH_I2C1_SCL", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@323 PS4, Line 323: "*GPIO_138", "LPSS_I2C7_SDA","ISH_I2C2_SDA", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@324 PS4, Line 324: "*GPIO_139", "LPSS_I2C7_SCL","ISH_I2C2_SCL", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@326 PS4, Line 326: "*GPIO_147", "ISH_GPIO_1", "AVS_I2S6_WS_SYNC", "AVS_HDA_WS_SYNC", line over 80 characters
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@329 PS4, Line 329: "*GPIO_150", "ISH_GPIO_4", "AVS_I2S5_BCLK", "LPSS_UART2_RXD", line over 80 characters
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@330 PS4, Line 330: "*GPIO_151", "ISH_GPIO_5", "AVS_I2S5_WS_SYNC", "LPSS_UART2_TXD", line over 80 characters
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@331 PS4, Line 331: "*GPIO_152", "ISH_GPIO_6", "AVS_I2S5_SDI", "LPSS_UART2_RTS_B", line over 80 characters
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@332 PS4, Line 332: "*GPIO_153", "ISH_GPIO_7", "AVS_I2S5_SDO", "LPSS_UART2_CTS_B", line over 80 characters
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@339 PS4, Line 339: "OSC_CLK_OUT_0","*OSC_CLK_OUT_0", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@340 PS4, Line 340: "OSC_CLK_OUT_1","*OSC_CLK_OUT_1", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@341 PS4, Line 341: "OSC_CLK_OUT_2","*OSC_CLK_OUT_2", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@342 PS4, Line 342: "OSC_CLK_OUT_3","*OSC_CLK_OUT_3", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@343 PS4, Line 343: "OSC_CLK_OUT_4","*OSC_CLK_OUT_4", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@344 PS4, Line 344: "*PMU_AC_PRESENT","PMU_AC_PRESENT", "n/a", "n/a", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29897/4/util/inteltool/gpio_groups.c@353 PS4, Line 353: "*PMU_WAKE_B", "PMU_WAKE_B/EMMC_PWR_EN_N","n/a", "n/a", space required after that ',' (ctx:VxV)